Skip to content

Filter pending and running #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Filter pending and running #7

merged 1 commit into from
Sep 3, 2018

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Sep 3, 2018

The aws_get_instances_with_tag should only return instances in the pending/running state

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that this is a backwards incompatible change. Might need to update tests too?

@brikis98
Copy link
Member

brikis98 commented Sep 3, 2018

Ah, looks like tests are passing as-is, n/m.

@tonerdo tonerdo merged commit afa3e0d into master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants