Skip to content

[APT-1699] Add link to docs for CIS compliant services #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

ebeneliason
Copy link
Contributor

This refactors the Modal component into a general purpose one, and introduces
two custom flavors for displaying 'subscription required' notices of general
and CIS flavor. These two types of modals appear independently, and we track
the warning preferences for each.

@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit dc33c37
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/623cf924bd9ce30009a50c5a
😎 Deploy Preview https://deploy-preview-230--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

eak12913
eak12913 previously approved these changes Mar 24, 2022
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed live.

This refactors the Modal component into a general purpose one, and introduces
two custom flavors for displaying 'subscription required' notices of general
and CIS flavor. These two types of modals appear independently, and we track
the warning preferences for each.
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@ebeneliason ebeneliason merged commit 4f904b2 into master Mar 24, 2022
@ebeneliason ebeneliason deleted the apt-1699-cis-docs-link branch March 24, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants