Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --skip-pull-requests behavior #86

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix --skip-pull-requests behavior #86

merged 1 commit into from
Jul 28, 2022

Conversation

zackproser
Copy link
Contributor

Description

Fixes #71.

Depends on #85, which must be merged first.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Fix --skip-pull-requests logic so that pull requests are skipped and the default branch can be used as a target.

Migration Guide

yorinasub17
yorinasub17 reviewed Jul 20, 2022
View reviewed changes
Copy link

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just spotted a merge conflict with the concurrency bug fix.

repository/repo-operations.go Outdated Show resolved Hide resolved
@pete0emerson pete0emerson self-requested a review July 28, 2022 16:35
pete0emerson
pete0emerson approved these changes Jul 28, 2022
View reviewed changes
Copy link

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zackproser
Copy link
Contributor Author

Thanks for reviews! Going to merge this in now.

@zackproser zackproser merged commit d7c7074 into master Jul 28, 2022
@zackproser zackproser deleted the bug/71 branch July 28, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorinasub17 yorinasub17 yorinasub17 left review comments

@pete0emerson pete0emerson pete0emerson approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

@rhoboat rhoboat Awaiting requested review from rhoboat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--skip-pull-requests not working
3 participants
@zackproser @pete0emerson @yorinasub17