Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EKS 1.28 #213

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Add support for EKS 1.28 #213

merged 3 commits into from
Nov 4, 2023

Conversation

ryehowell
Copy link
Contributor

Description

Fixes #212.

This PR adds support for EKS 1.28 and drops support for EKS 1.23.

Documentation

TODOs

Read the Gruntwork contribution guidelines.

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@ryehowell ryehowell changed the title [WIP] Add support for EKS 1.28 Add support for EKS 1.28 Nov 3, 2023
pras111gw
pras111gw approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@pras111gw pras111gw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryehowell ryehowell merged commit decec19 into main Nov 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pras111gw pras111gw pras111gw approved these changes

@MoonMoon1919 MoonMoon1919 MoonMoon1919 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for EKS 1.28
3 participants
@ryehowell @MoonMoon1919 @pras111gw