Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coredns to execute a rollout when no patch is required. #224

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ryehowell
Copy link
Contributor

Description

Fixes #223

This PR adds a deployment rollout when a patch isn't required for coredns. This is necessary to ensure coredns is scheduled on Fargate when a patch operation doesn't take place. Without the update the coredns deployment will remain in the pending state.

Documentation

TODOs

Read the Gruntwork contribution guidelines.

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Release Notes (draft)

  • Update schedule coredns to perform a rollout when patch operation isn't executed for scheduling coredns on Fargate.

Migration Guide

@ryehowell ryehowell merged commit e040659 into main Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreDNS on Fargate stuck in pending state
2 participants