Fix/Feature: Lockstep #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2024
gschup
commented
Jun 1, 2024
| self.local_inputs.clear(); | ||
| requests.push(GgrsRequest::AdvanceFrame { inputs }); | ||
| } else { | ||
| println!( |
There was a problem hiding this comment.
There should not be an ugly print like that. Maybe a proper logging crate would be useful?
|
Anything blocking this PR? This fixes a panic that I'm running into :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several bugs in the sync layer / input_queue logic. This now allows for max_prediction_window to be set to 0 and thus falling back to lockstep netcode (with unnecessary gamestate save requests).