Fix hanging matlab errors

[DavidRitzwoller]

This is a follow up to here.

When working here, I noticed that build_matlab hangs when an error is encountered, rather than exiting and returning an error message.

@z-y-huang believes he fixed this bug in a separate project. I will start by testing his solution. He notes

See` Stack Overflow thread here about exceptions. You'll have to adjust based on your logging options, I think.

[DavidRitzwoller]

No work on this in past two weeks

[DavidRitzwoller]

No work on this in past two weeks

[z-y-huang]

process = subprocess.Popen(command.split(), 
                           stdout = subprocess.PIPE, 
                           stderr = subprocess.PIPE, 
                           shell = self.shell)
stdout, stderr = process.communicate()

matlab -nosplash -nodesktop -r run(\'%s\') -logfile %s'

First %s is program, second %s is log.

EDIT: Realized I also have a try/catch in my .m script. If you want the try/catch on the command line, use the following.

matlab -nosplash -nodesktop -r "try run(\'%s\'); catch e, fprintf(getReport(e)); end; quit" -logfile %s'

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[mengsongouyang]

Seems that the cross-polar project encounters a similar issue. Details in this post and the followings.

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past two weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

no progress in past 2 weeks

[DavidRitzwoller]

@mengsongouyang. I'm going to pass you this task for the time being

[mengsongouyang]

No progress in past two weeks.

[zkashner]

@Houdanait if you have some time and are willing to explore this issue that would be awesome!

[Houdanait]

Yes ! @zkashner

[Houdanait]

@zkashner @yu-jia-wang, linking this with fix_latex_error and i might have a suggestion for this

[Houdanait]

Hi @yu-jia-wang, thanks for offering to check that the suggested change for Latex indeed works for Matlab as well. I have tried faking an error on a .m file and it worked. It would be great if we could actually test this on a repo with an existing hanging Matlab issue to make sure this work. We have just merged it to gslab repo so you should be able to check it out.
There is now a time out option in ProgramDirective.py (l.115 here ) which should lead to exit when an app is hanging.

Let me know if this worked!! Thanks!

[liaochris]

Branch updated from master in 225baef