-
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
It's a shame you had to do this manually cuz there's nothing here the generator couldn't do (remember |
/// Retrieves the OpenGL version of the context. | ||
/// | ||
/// The context must be realized prior to calling this function. | ||
pub fn get_version(&self, major: &mut i32, minor: &mut i32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator will return these in a tuple so to avoid breakage I'd suggest doing the same.
Example: gtk-rs/gir#122 (comment)
It does ?! Impressive ! |
Well, I have to admit it doesn't add the docs yet. Also |
Too bad. Well, I think we'll still need to add it ourselves. (Updated btw) |
/// The context must be realized prior to calling this function. | ||
pub fn get_version(&self) -> (i32, i32) { | ||
let major = 0; | ||
let minor = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mut
?
That's why I hate writing without having the possibility to test it... |
Looks like we'll have to learn to build this stuff from source anyway. And a chroot is not too difficult to set up. |
It's not an I know, this boilerplate begs for a macro. I was hoping to avoid them previously. Looks like macros |
} | ||
|
||
/// Retrieves the GLContext that this context share data with. | ||
pub fn get_shared_context(&self) -> Option<Window> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns Option<GLContext>
perhaps?
This is good at last! :) |
No description provided.