Problem with generating enums/flags where the get_type() function was added later

[sdroege]

E.g. https://gitlab.freedesktop.org/gstreamer/gstreamer-rs-sys/blob/master/gstreamer-video-sys/src/lib.rs#L2332

This get_type() function was added in 1.16, the corresponding flags type exists since much longer.

There are two problems here
a) In GStreamer this function needs to be marked as Since: 1.16
b) We need to generate the #[cfg()] thing for it in the -sys crate
c) We need to figure out how to handle that conditional compilation in the non-sys crate

Thoughts?

[EPashkin]

"a" and "b" IMHO fixing by changing GstVideo-1.0.gir,
for "c" IMHO if there any value that custom gtk_align_get_type can return without broke all,
then simpler just add manual function to sys crate with inverse condition,
so no changes will needed in non-syses

[EPashkin]

Alternative also needed fixes for "a" and "b" anyway.
We can compare versions for "get_type" and "enum" and if get_type added later not generate "StaticType" and "*Value"* traits for enum.

[sdroege]

"a" and "b" IMHO fixing by changing GstVideo-1.0.gir,

Probably, but would we even generate the b) for the -sys crate?

for "c" IMHO if there any value that custom gtk_align_get_type can return without broke all,
then simpler just add manual function to sys crate with inverse condition,
so no changes will needed in non-syses

We can't implement our own get_type function. We'd have to put the whole StaticType and GValuer traits impls into #[cfg]

[EPashkin]

About "b": IMHO get_type is normal function so "[cfg]" will be generated with right .gir file.

You right that instead not generating we can add "[cfg]" to trait "StaticType" etc.

"Breaking change" alternative just increase enum version to match get_type's.

[EPashkin]

About "b" if you meant "inverse function" then seems we can't generate it 😢

[sdroege]

"Breaking change" alternative just increase enum version to match get_type's.

That's not an option for GStreamer unfortunately :)

[sdroege]

Ok, so we have a plan I guess.