Make auto builders/traits/functions pub(crate)
#1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/random
branch
from
7d4a145
to
e96cd8f
Compare
As they are supposed to be re-exported through functions/builders/prelude from the main lib
bilelmoussaoui
force-pushed
the
bilelmoussaoui/random
branch
from
e96cd8f
to
6b6fabf
Compare
sdroege
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently clippy would complain about a pub mod in auto having the same name as the outer mod. We should just make these mods
pub(crate)and ask the user to explicitly re-export them. This solves the clippy lint complaint without having to rename any files.