CI/tests: Remove gtk3 related bits #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the crate is no longer maintained; don't use it as a blocker in our CI/tests
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gtk3-phase-out
branch
from
b1f31c9
to
a81320b
Compare
sdroege
approved these changes
Jan 26, 2024
|
Can you add an issue for adding gtk4 and/or gst? |
It already regen & builds gtk4. But I didn't add it to the windows tests and didn't add a sys regen from scratch like we currently do for glib, I think we should also remove that :) |
Those tests don't do much interesting, attempting to regen ffi crates is something already done by cloning the gtk-rs-core repo and regen/build it
|
I pushed another commit to fully phase out those old ffi regen tests |
sdroege
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the crate is no longer maintained; don't use it as a blocker in our CI/tests