Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen clippy fixes #1566

Merged
merged 4 commits into from
May 17, 2024
Merged

Codegen clippy fixes #1566

merged 4 commits into from
May 17, 2024

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the clone_into() but if it still builds everything...

@bilelmoussaoui
Copy link
Member Author

I'm not a fan of the clone_into() but if it still builds everything...

Not a fan either, just applied cargo clippy --fix here, could silence the lint if that is your preference

@bilelmoussaoui
Copy link
Member Author

I'm not a fan of the clone_into() but if it still builds everything...

Reverted and silenced the warnings instead

@bilelmoussaoui bilelmoussaoui merged commit 839b834 into master May 17, 2024
7 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/fixes branch May 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants