Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trust_return_value_nullability after making sure it doesn't cause regressions #789

Closed
6 tasks done
sdroege opened this issue Oct 11, 2022 · 3 comments · Fixed by #905
Closed
6 tasks done

Use trust_return_value_nullability after making sure it doesn't cause regressions #789

sdroege opened this issue Oct 11, 2022 · 3 comments · Fixed by #905
Labels
help wanted Extra attention is needed
Milestone
0.17.0

Comments

@sdroege
Copy link
Member

sdroege commented Oct 11, 2022 •
edited
Loading

CC @bilelmoussaoui @GuillaumeGomez
@sdroege sdroege added the help wanted Extra attention is needed label Oct 11, 2022
@sdroege sdroege added this to the 0.17.0 milestone Oct 11, 2022
@sdroege sdroege mentioned this issue Oct 11, 2022
Open
4 tasks
@GuillaumeGomez
Copy link
Member

I'll try to take a look in the next days.

@GuillaumeGomez
Copy link
Member

For pango, we need to wait for my MRs to be merged:

And for new GIR files to be generated.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 14, 2022
Merged
@GuillaumeGomez
Copy link
Member

And for gdk-pixbuf we need to wait for https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/merge_requests/146.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 16, 2022
Merged
@sdroege sdroege mentioned this issue Jan 21, 2023
Merged
AaronErhardt pushed a commit to AaronErhardt/gtk-rs-core that referenced this issue Feb 11, 2023
@sdroege @AaronErhardt
gdk-pixbuf: Trust return value nullability
c3fc1c2 
Fixes gtk-rs#789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

gdk-pixbuf: Trust return value nullability sdroege/gtk-rs-core
2 participants
@sdroege @GuillaumeGomez