Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTAINER to component event type #1497

Merged
merged 2 commits into from
May 28, 2024
Merged

Add CONTAINER to component event type #1497

merged 2 commits into from
May 28, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented May 28, 2024 •
edited
Loading

What are you changing?

  • Adds "CONTAINER" to OphanComponentEvent type

Why?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bd86a71

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels May 28, 2024
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label May 28, 2024
@cemms1 cemms1 marked this pull request as ready for review May 28, 2024 11:32
@cemms1 cemms1 requested a review from a team as a code owner May 28, 2024 11:32
@cemms1 cemms1 requested a review from a team May 28, 2024 11:32
@cemms1 cemms1 requested review from a team as code owners May 28, 2024 11:32
@cemms1 cemms1 mentioned this pull request May 28, 2024
Merged
@cemms1 cemms1 merged commit 013fed6 into main May 28, 2024
21 checks passed
@cemms1 cemms1 deleted the cemms1/add-container-component-event branch May 28, 2024 15:59
@mxdvl
Copy link
Contributor

mxdvl commented May 28, 2024

Hopefully this package is soon superceded by ophan-tracker-js providing its own types…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett approved these changes

Assignees
No one assigned
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemms1 @mxdvl @jamesmockett