Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude original metadata from free text search #4056

Merged
merged 1 commit into from
May 23, 2023

Conversation

abdelrahmansd
Copy link
Contributor

@abdelrahmansd abdelrahmansd commented Mar 28, 2023

What does this change?

update elastic search Mapping excludes original metadata from free text search (englishAnalysedCatchAll)

How should a reviewer test this change?

clean and set-up the grid locally to create the new mapping
upload an image and edit any field of originalMetadata
free text search of the old text should not get any result

How can success be measured?

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@honorcb
Copy link
Collaborator

honorcb commented Apr 5, 2023

This is to resolve an issue reported by BBC News Archivists, after correcting the spelling of names in Agency wire pictures, It was not an issue for the GRID users https://journalism-tools-dev.slack.com/archives/CHYRSQ673/p1678457702896019

@abdelrahmansd abdelrahmansd marked this pull request as ready for review April 12, 2023 10:26
@abdelrahmansd abdelrahmansd requested a review from a team as a code owner April 12, 2023 10:26
@paperboyo paperboyo added the bbc label May 5, 2023
Copy link
Contributor

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in our TEST environment with @paperboyo and it does work, but contrary to what we stated at grid hour today will require a 'migration' before this change applies to ANY images (i.e. including new images following this PR being merged).

We're still deciding whether we'll run a migration imminently to benefit from this ourselves, will let you know. Regardless, the offer still stands to assist BBC with their first migration (which is more pressing now we know this PR will have no effect at all until after migration).

@prout-bot
Copy link

Seen on collections, leases, usage, kahuna (created by @abdelrahmansd and merged by @twrichards 10 minutes and 52 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on metadata-editor, thrall, cropper, media-api (created by @abdelrahmansd and merged by @twrichards 10 minutes and 59 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on auth (created by @abdelrahmansd and merged by @twrichards 11 minutes and 3 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on image-loader (created by @abdelrahmansd and merged by @twrichards 11 minutes and 10 seconds ago) Please check your changes!

3 similar comments
@prout-bot
Copy link

Seen on image-loader (created by @abdelrahmansd and merged by @twrichards 11 minutes and 10 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on image-loader (created by @abdelrahmansd and merged by @twrichards 11 minutes and 10 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on image-loader (created by @abdelrahmansd and merged by @twrichards 11 minutes and 10 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants