Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both .yml and .yaml file extensions plugin manifests #3097

Closed
cakekoa opened this issue Mar 13, 2023 · 0 comments
Closed

Support both .yml and .yaml file extensions plugin manifests #3097

cakekoa opened this issue Mar 13, 2023 · 0 comments
Assignees
@shreyamalviya
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Medium Plugins sp/3
Milestone
v2.2.0

Comments

@cakekoa
Copy link
Contributor

cakekoa commented Mar 13, 2023 •
edited by mssalvatore
Loading

Problem

Both .yml and .yaml are valid YAML file extensions. We only support the .yaml extension for the plugin manifest file, but we should support both.

Solution

Fix:

  • PluginArchiveParser
  • The plugin build script
@cakekoa cakekoa added the Feature Issue that describes a new feature to be implemented. label Mar 13, 2023
@mssalvatore mssalvatore added v2.2.0 and removed v2.2.0 labels Mar 28, 2023
@mssalvatore mssalvatore added this to the v2.2.0 milestone Mar 28, 2023
@shreyamalviya shreyamalviya self-assigned this May 9, 2023
@shreyamalviya shreyamalviya mentioned this issue May 9, 2023
Closed
10 tasks
mssalvatore added a commit that referenced this issue May 9, 2023
@mssalvatore
Merge branch '3097-support-manifests-with-yml' into develop
0ca03b3 
Issue #3097
PR #3325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyamalviya shreyamalviya

Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Medium Plugins sp/3
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Support manifest.yml guardicore/monkey
3 participants
@cakekoa @mssalvatore @shreyamalviya