Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgentOTPProvider #3113

Merged
merged 5 commits into from
Mar 15, 2023
Merged

AgentOTPProvider #3113

merged 5 commits into from
Mar 15, 2023

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Mar 15, 2023

What does this PR do?

Fixes a part of #3077

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (4cb02a6) 67.63% compared to head (e0e2510) 67.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3113      +/-   ##
===========================================
+ Coverage    67.63%   67.66%   +0.03%     
===========================================
  Files          446      447       +1     
  Lines        12775    12783       +8     
===========================================
+ Hits          8640     8650      +10     
+ Misses        4135     4133       -2     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but rename

@shreyamalviya shreyamalviya merged commit 0597fa9 into develop Mar 15, 2023
@shreyamalviya shreyamalviya deleted the 3077-implement-otp-provider branch March 15, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants