Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Behaviour when LLM is None #983

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix Behaviour when LLM is None #983

merged 1 commit into from
Aug 1, 2024

Conversation

CalebCourier
Copy link
Collaborator

@CalebCourier CalebCourier commented Aug 1, 2024

Previously, if the llm_api argument was None and OPENAI_API_KEY environment variable was not set, the llm_api would match the static openai completions create function because it was returning None. This would cause issues as shown in #979

We now avoid this issue by:

  1. Not matching to an LLM if the llm_api argument is None and there is no model argument specified.
  2. Not returning None from the static openai fetcher methods. If auth is not properly set, let the OpenAI errors propagate up accordingly.

@dtam dtam merged commit 4872f8f into main Aug 1, 2024
12 checks passed
@dtam dtam deleted the llm-api-fix branch August 1, 2024 18:04
@zsimjee zsimjee added this to the v0.5.3 Release Tracker milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants