Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid guess when season is in another language #277

Closed
labrys opened this issue Feb 21, 2016 · 6 comments
Closed

Invalid guess when season is in another language #277

labrys opened this issue Feb 21, 2016 · 6 comments
Milestone

Comments

@labrys
Copy link
Contributor

labrys commented Feb 21, 2016

If the word season is in another language (e.g. Seizon) it is not detected

>>> guessit('Vikings.Seizoen.4.1080p.Web.NLsubs')
MatchesDict([('title', 'Vikings Seizoen 4'), ('screen_size', '1080p'), ('format', 'WEB-DL'), ('release_group', 'NLsubs'), ('type', 'movie')])
>>> guessit('Vikings.Season.4.1080p.Web.NLsubs')
MatchesDict([('title', 'Vikings'), ('season', 4), ('screen_size', '1080p'), ('format', 'WEB-DL'), ('release_group', 'NLsubs'), ('type', 'episode')])
@Toilal
Copy link
Member

Toilal commented Feb 21, 2016

Please provide a list of all words/language we could support. Same for
episode.
Le 21 févr. 2016 18:45, "Labrys of Knossos" notifications@github.com a
écrit :

If the word season is in another language (e.g. Seizon) it is not detected

guessit('Vikings.Seizoen.4.1080p.Web.NLsubs')
MatchesDict([('title', 'Vikings Seizoen 4'), ('screen_size', '1080p'), ('format', 'WEB-DL'), ('release_group', 'NLsubs'), ('type', 'movie')])>>> guessit('Vikings.Season.4.1080p.Web.NLsubs')
MatchesDict([('title', 'Vikings'), ('season', 4), ('screen_size', '1080p'), ('format', 'WEB-DL'), ('release_group', 'NLsubs'), ('type', 'episode')])


Reply to this email directly or view it on GitHub
#277.

@labrys
Copy link
Contributor Author

labrys commented Feb 21, 2016

This will have to be a dynamic list of course, but I'll start putting one together... one instance that comes to mind that may pose an issue is that Season is Series in the UK.

@Toilal Toilal added this to the 2.1 milestone Apr 9, 2016
@ratoaq2
Copy link
Member

ratoaq2 commented Jun 5, 2016

Spanish and Portuguese:

  • Season = Temporada (Temp - abbreviated)
  • Seasons = Temporadas

Spanish

  • Episode = Episodio
  • Episodes = Episodios
  • Chapter = Capitulo (Cap - abbreviated)

Portuguese:

  • Episode = Episódio
  • Episodes = Episódios
  • Chapter = Capítulo

And some examples

guessit 2.0.5
guessit "American.Crime.-.Temporada.1.720p.HDTV.x264[Cap.102]SPANISH.AUDIO-NEWPCT"
For: American.Crime.-.Temporada.1.720p.HDTV.x264[Cap.102]SPANISH.AUDIO-NEWPCT
GuessIt found: {
    "title": "American Crime", 
    "alternative_title": "Temporada 1", 
    "screen_size": "720p", 
    "format": "HDTV", 
    "video_codec": "h264", 
    "season": 1, 
    "episode": 2, 
    "language": "Spanish", 
    "episode_title": "AUDIO-NEWPCT", 
    "type": "episode"
}

when enabling implicit=True, then it adds the season 1 to the episode list as well.

Another example:

guessit Sons.of.Anarchy.-.Temp.1.DVDrip.x264[Cap.107_108]SPANISH.AUDIO-NEWPCT
For: Sons.of.Anarchy.-.Temp.1.DVDrip.x264[Cap.107_108]SPANISH.AUDIO-NEWPCT
GuessIt found: {
    "title": "Sons of Anarchy", 
    "alternative_title": "Temp 1", 
    "format": "DVD", 
    "video_codec": "h264", 
    "season": 1, 
    "episode": 8, 
    "language": "Spanish", 
    "episode_title": "AUDIO-NEWPCT", 
    "type": "episode"
}

@Toilal Toilal modified the milestones: 2.0.6, 2.1, 2.2 Jul 1, 2016
@ratoaq2
Copy link
Member

ratoaq2 commented Mar 2, 2017

Season in dutch is handled by #420.

But it's still not possible to have them configurable, not yet.

@Toilal
Copy link
Member

Toilal commented Oct 18, 2018

It seems to be supported now in configuration file.

@Toilal Toilal closed this as completed Oct 18, 2018
@ratoaq2
Copy link
Member

ratoaq2 commented Oct 19, 2018

I'm still alive 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants