Skip to content

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 3, 2021

With this PR in the same console it's allows 3 types of Toplevels:

  1. Non persistent toplevel always recreating the Application.Top.
  2. A single persistent toplevel maintained his state. (See SingleBackgroundWorker.cs scenario)
  3. Multi persistent toplevels representing Mdi childes of the Mdi container, allowing multi instances of a class with the windows navigation feature between them. (See BackgroundWorkerCollection.cs scenario)

mdi-container

@BDisp BDisp marked this pull request as draft June 4, 2021 11:47
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please break the parts of this PR that are distinct into separate PRs?

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 4, 2021

Can you please break the parts of this PR that are distinct into separate PRs?

Done @tig. Thanks.

@BDisp BDisp marked this pull request as draft June 5, 2021 07:43
@BDisp BDisp marked this pull request as ready for review July 10, 2021 23:21
@BDisp BDisp requested a review from tig July 13, 2021 20:21
@BDisp BDisp marked this pull request as draft July 14, 2021 13:56
@BDisp BDisp marked this pull request as ready for review July 16, 2021 06:24
@tig
Copy link
Collaborator

tig commented Jul 21, 2021

My deepest apologies for taking so long on this (and others). I've been pretty busy. But I will get through all the PRs asap!

@tig tig merged commit 5f03261 into gui-cs:main Jul 21, 2021
@BDisp BDisp deleted the toplevel-improvement branch July 21, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants