Skip to content

Test enhancement #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2018
Merged

Test enhancement #103

merged 6 commits into from
Feb 7, 2018

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Feb 1, 2018

Changed log

  • Add more tests
  • Sperate the classes. One class is mapped a PHP file.
  • Integrate the coveralls service and it's a code coverage service.
  • Add the required PHP extensions checking when Composer do the package installation.
  • Add autoload-dev to generate the test autoload files.
  • Modify the addFilter method because the imagefilter function needs the two arguments.
  • Implement the imageFlip method in ImageResize class.
    It's for the PHP version is lower than 5.5.
  • Drop PHP 5.3 and set required PHP version is 5.4+ in composer.json.

Here is Travis build and the code coverage report by coveralls.

@adityapatadia
Copy link
Contributor

adityapatadia commented Feb 6, 2018

Thanks for an amazing update. I really appreciate your work.
Can you add following things as well which will help me directly merge this in master.

  1. Update the readme file for imageFlip
  2. Add coveralls test badge to readme

It would be also good if you can remove the editorconfig file.

@peter279k
Copy link
Contributor Author

Hi @adityapatadia, thank you for your reply.
The imageFlip usage I have added in README.md.
And the .editorconfig has been removed.
BTW, the coveralls test badge I think it needs to be added on your own because the coveralls badge link is point at my forked repo.

Thanks.

@adityapatadia adityapatadia merged commit f6fb03f into gumlet:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants