Skip to content

Added some docblocks and support for string-based file loading and saving. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2015

Conversation

Droeftoeter
Copy link
Contributor

No description provided.

@adityapatadia
Copy link
Contributor

Hey, I see huge gitignore file. Please do something about it. Apart from that, it would be great if you can also update readme.

@Droeftoeter
Copy link
Contributor Author

Done!

@adityapatadia
Copy link
Contributor

Can you please check the current code. I recently merged another branch and it is conflicting.

@Droeftoeter
Copy link
Contributor Author

Merged it, should be good now.

@popadko
Copy link
Contributor

popadko commented Jan 26, 2015

Why toString not magic method __toString?

@adityapatadia
Copy link
Contributor

@Sjaakmoes going to implement __toString?

@adityapatadia
Copy link
Contributor

Everything looks fine. I am merging it. Send new PR if you implement __toString.

adityapatadia added a commit that referenced this pull request Jan 26, 2015
Added some docblocks and support for string-based file loading and saving.
@adityapatadia adityapatadia merged commit ef0505a into gumlet:master Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants