Better crop, cleaner chaining #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 22, 2014 14:20
- allows non-destructive chaining of operations
- move actual image manipulation to output()/save() so we can handle transparency better - this allows changing between image types to work properly - output header when rendering image directly in browser - fix crop() method
|
Hi, it is great improvement. I am going to merge it. It would also be great if you can write some PHPUnit test for this library. |
|
I am also going to tag it as v1.0.0 and v1.1.0 so it would be great if you can send PR for updated read me. |
adityapatadia
added a commit
that referenced
this pull request
Jun 25, 2014
Better crop, cleaner chaining
|
No problem, see #5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a pull request for changes I've made to your library for issues that have arisen while using it.
It should be fully backwards compatible.
See commit logs for changes.
Basically better cropping, and keeping the source image and dimensions while doing resize operations, so chaining them will result in as little loss of image information as possible.
It might be a good idea to tag your current state as
1.0.0and if you accept this PR, tag it as1.1.0. This would be really helpful when using Composer.Please let me know if you have any queries.
Thanks for the simple but very useful class.