Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add shortcut API for finding tile bounds #297

Closed
nightm4re94 opened this issue Dec 20, 2019 · 0 comments
Closed

Re-Add shortcut API for finding tile bounds #297

nightm4re94 opened this issue Dec 20, 2019 · 0 comments
Assignees
Milestone

Comments

@nightm4re94
Copy link
Member

With 3a01c22, the convenient methods to find tile bounds were moved to IMapOrientation. Accessing these methods in a non-static way is far more tedious, as the comparison below shows:

Syntax before:

MapUtilities.getTileBoundingBox(Point2D targetTile)

Syntax after:

Game.world().environment().getMap().getOrientation().getBounds(Point2D targetTile, Game.world().environment().getMap());

We should add static shortcuts again that call the instance methods for the current MapOrientation.

@TheRamenChef TheRamenChef self-assigned this Dec 20, 2019
@nightm4re94 nightm4re94 added this to the v0.5.0-beta milestone Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants