Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Emitter editing #298

Closed
steffen-wilke opened this issue Dec 28, 2019 · 4 comments · Fixed by #346
Closed

Fix Emitter editing #298

steffen-wilke opened this issue Dec 28, 2019 · 4 comments · Fixed by #346

Comments

@steffen-wilke
Copy link
Contributor

Currently, the dialog that allows editing emitters in the utiLITI editor has some major issues:

image

  • UI-wise the elements are misaligned and some are not fully readable (see screenshot) this makes the UI hard to use and understand
  • When trying to create a new emitter from scratch in the editor, this doesn't seem to be possible at the moment; at least I wasn't able to get a visible result.
    • Some investigations showed, that a lot of ParticleParameters are not serialized properly (maybe unchanged values, especially the max values are not set as custom property?)
  • I would say that this feature is entirely broken right now, unless you have an already working emitter and just want to tweak some numbers.
  • When adding a new emitter, we should define appropriate default values so the user can already see something

image

We might also think about integrating these settings from the separate modal dialog to the normal PropertyPanel in order to enable live feedback on the changes in the editor and reduce the friction to play around with Emitter settings.
Alternatively, there should be at least a preview of the emitter in the modal dialog.

@steffen-wilke steffen-wilke added bug tool: utiLITI MAJOR This label is intended to distinguish major features from all the others. labels Dec 28, 2019
@steffen-wilke steffen-wilke added this to the v0.5.0-beta milestone Dec 28, 2019
@nightm4re94 nightm4re94 added urgent! and removed MAJOR This label is intended to distinguish major features from all the others. labels Feb 10, 2020
@nightm4re94
Copy link
Member

Some more requirements:

  • Exporting Emitters as xml
  • Making Custom Emitters usable as EntityEmitters

@nightm4re94
Copy link
Member

nightm4re94 commented May 18, 2020

To make the whole editor component less overwhelming, we could consider an approach similar to Unity's Particle System Modules, where you can toggle behaviours such as velocity over lifetime / size over lifetime separately.

Being able to hide modules makes this a clean alternative to how our emitter panel looks.:

@nightm4re94
Copy link
Member

In my recent Branch, I am redesigning the Emitter modification process in utiLITI from scratch.

@nightm4re94
Copy link
Member

The new panel also needs to contain controls for particle rotation as requested per #345 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants