Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit message suggestion #87

Closed
CMCDragonkai opened this issue Mar 21, 2014 · 11 comments
Closed

Git commit message suggestion #87

CMCDragonkai opened this issue Mar 21, 2014 · 11 comments

Comments

@CMCDragonkai
Copy link

Would be great if Gush could setup a good git commit message formatting, such as text length (automatic new line) if the message is too long..etc.

Some ideas:

http://karma-runner.github.io/0.8/dev/git-commit-msg.html
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
http://stackoverflow.com/questions/15324900/standard-to-follow-when-writing-git-commit-messages

@cordoval
Copy link
Member

👍

@cordoval
Copy link
Member

which one you prefer @CMCDragonkai ?

@CMCDragonkai
Copy link
Author

Karma's one seem pretty good. But we can use a strategy pattern. Basically we can have templating classes. One of them fits Karma, and people can extend it for further customisation and drill down.

Also I don't think it should be called "Karma", just "default" templating.

@cordoval
Copy link
Member

yeah @CMCDragonkai if you send a PR we will work on it, want to do that? I am excited, tonight we also merge support for BitBucket!

@CMCDragonkai
Copy link
Author

Hey @cordoval you might have to wait for a bit for me to write a pull-request. Currently busy with other projects. Perhaps other people might take this suggestion up.

@cordoval
Copy link
Member

oh we will do it before you can send a PR hopefully! thanks for your suggestion keep it up man! /o/

@cordoval
Copy link
Member

bump @CMCDragonkai wanna take a stab please? 👶

@cordoval
Copy link
Member

I reviewed the 3 links.

are you saying we should have a command to commit? like gush p:commit?
I really want to more have an integrator command, i often type through the day

gush i:take x; git a; git ca "x"; gush b:p; gush p:create --issue=x; gush p:merge x; gush b:d; git checkout master; git branch -d x_branch_name

This cycle repeats like n times every n PRs i do daily cc/ @lsmith77

@cordoval
Copy link
Member

let's dicuss this more in the context of the other tickets because we have to reach more integration ideas of the flows that we want to use/support.

@CMCDragonkai
Copy link
Author

Which tickets are you referring to?

And yes a commit command!

@cordoval
Copy link
Member

not sure, lot of time has passed, try the editor helper on commit maybe, but think about the PR to make it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants