This repository has been archived by the owner on Aug 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect
The following code would fail to await the
aiohttp.ClientSession.close()
coroutine, or attempt to close the session after the event loop closed.Desired behavior
Changes
__aenter__
,__aexit__
, andclose
functions__del__
function. For well-handled cleanup, clients can either explicitly close, or use the context guard. This also avoids unwanted side effects where__del__
is called after the event loop closes.async_client
fixture is now async, and uses a module scoped event loop