Skip to content

Conversation

keinhaar
Copy link
Contributor

@keinhaar keinhaar commented Aug 1, 2024

No description provided.

@keinhaar keinhaar requested a review from protoism August 1, 2024 22:34
Copy link
Contributor

@protoism protoism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

There are some traces of sdbg in mirrors directory.
I'd say that the mirror target was something like "copy this p2 repo here", but it has been disabled.
If you feel that it is the case, maybe we can reinsert sdbg?
Anyway your patch should really fix the problem you wanted to fix.
Thanks.

@keinhaar keinhaar closed this Aug 1, 2024
@keinhaar keinhaar reopened this Aug 1, 2024
@keinhaar
Copy link
Contributor Author

keinhaar commented Aug 1, 2024

Can you merge this? I dont have the permission.

@protoism
Copy link
Contributor

protoism commented Aug 1, 2024

Can you merge this? I dont have the permission.

As soon as the CI completes

@protoism protoism merged commit 724cbc0 into gwt-plugins:main Aug 1, 2024
@keinhaar keinhaar deleted the v4.1 branch September 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants