Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract units from SBML and implement operations #185

Merged
merged 11 commits into from
Jul 5, 2023
Merged

Extract units from SBML and implement operations #185

merged 11 commits into from
Jul 5, 2023

Conversation

bgyori
Copy link
Member

@bgyori bgyori commented Jun 28, 2023

This PR implements the extraction and normalization of units from SBML. It also implements handling of units when models are changed to aggregate multiple parameters.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #185 (36237b6) into main (79a11a9) will increase coverage by 0.02%.
The diff coverage is 79.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   76.45%   76.47%   +0.02%     
==========================================
  Files          65       65              
  Lines        4977     5024      +47     
==========================================
+ Hits         3805     3842      +37     
- Misses       1172     1182      +10     
Impacted Files Coverage Δ
mira/metamodel/ops.py 76.22% <0.00%> (-3.34%) ⬇️
mira/modeling/askenet/petrinet.py 95.70% <ø> (ø)
mira/sources/sbml/processor.py 59.79% <89.79%> (+2.74%) ⬆️
mira/resources/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bgyori bgyori merged commit 82421e4 into main Jul 5, 2023
@bgyori bgyori deleted the sbml_units branch July 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants