Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of plUruLauncher #65

Closed
diafero opened this issue Aug 2, 2011 · 2 comments
Closed

Get rid of plUruLauncher #65

diafero opened this issue Aug 2, 2011 · 2 comments

Comments

@diafero
Copy link
Member

diafero commented Aug 2, 2011

The starting phase of CWE with two binaries working together is needlessly complicated, not to mention all the duplicated code. The self-patching ability and the plClientPatcher should be moved to plClient and launched before showing the login dialogue (so that nothing changes for the user). Then we can also get rid of these hard-coded .exe filenames in the sources, I see no reason why we should not be able to call the executable the way we want without even recompiling.
The internal client can get a command-line option to skip the patching, to replicate the behaviour of directly calling plClient.

@diafero
Copy link
Member Author

diafero commented Aug 6, 2011

After giving the launcher a closer look, I changed my mind on this: It's not a good idea to merge it into plClient. It should be re-written entirely, from scratch... the subject still holds valid, though ;-)

@branan
Copy link
Member

branan commented Jan 21, 2013

Absolutely agree that plUruLauncher could be rewritten, but we'll always have a launcher app. I'm going to close this, and when we have a better idea how we want to handle launching we can open issues related to the fixes that need to be made.

@branan branan closed this as completed Jan 21, 2013
zrax pushed a commit to zrax/Plasma that referenced this issue Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants