Fix browsing/monitoring non-git directories #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update view model when selecting an empty/non-git directory so that UI refreshes correctly. Make sure the observable for the git directory creation event gets disposed after getting one event, so that FileSystemWatchers listening for creation events don't accumulate if the directory is created more than once.
|
|
||
| RepositoryPath = repositoryWorkingPath; | ||
| string gitPath = ModelExtensions.GetGitRepositoryPath(repositoryWorkingPath); |
There was a problem hiding this comment.
repositoryWorkingPath.GetGitRepositoryPath().
There was a problem hiding this comment.
GetGitRepositoryPath is not actually an extension method for strings (class name notwithstanding)
There was a problem hiding this comment.
That's what I get for reviewing without checking the code. 😭 Sorry!
haacked
added a commit
that referenced
this pull request
Jan 5, 2015
Fix browsing/monitoring non-git directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update view model when selecting an empty/non-git directory so that UI
refreshes correctly.
Make sure the observable for the git directory creation event gets
disposed after getting one event, so that FileSystemWatchers listening
for creation events don't accumulate if the directory is created more
than once.