[studio] Use system artifact cache dir when running studio as root. #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
This change was motivated by a bug fix to the artifact caching feature introduced in #2737 but upon closer inspection, a much better refactoring presented itself. The key bit of insight was to remember that on Linux systems where `sudo` will be called, we can set up the appropriate environment variables *before* we become the root user (under the hood we call `exec` with sudo to re-run the program with higher permissions). Now that all the home directory-related logic is run under the non-root user, there are far fewer edge conditions and we no longer need the logic which attempt to determine that original calling user via the `SUDO_USER` environment variable. Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
fnichol
force-pushed
the
fnichol/studio-sudo-refactor
branch
from
87c7345
to
a16daa8
Compare
|
I rebased against master so hopefully appveyor will pass now |
|
I'm building locally to test here |
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
1 similar comment
|
|
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus: Studio
christophermaier
added
Platform: Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was motivated by a bug fix to the artifact caching feature
introduced in #2737 but upon closer inspection, a much better
refactoring presented itself.
The key bit of insight was to remember that on Linux systems where
sudowill be called, we can set up the appropriate environmentvariables before we become the root user (under the hood we call
execwith sudo to re-run the program with higher permissions). Nowthat all the home directory-related logic is run under the non-root
user, there are far fewer edge conditions and we no longer need the
logic which attempt to determine that original calling user via the
SUDO_USERenvironment variable.I did to myself and to all of us way back. Tech debt paid down!