Add shrey.dino.icu and codethetech.hackclub.com
#1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please resolve conflicts |
|
Hey @JosiasAurel , I have resolved the conflicts |
grymmy
requested changes
Nov 21, 2023
grymmy
requested changes
Nov 27, 2023
dino.icu.yaml
Outdated
| @@ -369,3 +369,8 @@ xn--c1h: | |||
| xn--ct9h: | |||
| type: CNAME | |||
| value: b616c4f2-bfad-4b67-9c6d-ee6afc35cc0b.id.repl.co. | |||
|
|
|||
| shrey: | |||
| - ttl: 1 | |||
There was a problem hiding this comment.
The indentation of this section looks incorrect.
Muirrum
requested changes
Nov 28, 2023
Co-authored-by: Cara Salter <cara@devcara.com>
Muirrum
requested changes
Nov 29, 2023
Comment on lines
+2468
to
+2472
| codethetech: | ||
| - ttl: 1 | ||
| type: CNAME | ||
| value: codethetech.github.io | ||
|
|
There was a problem hiding this comment.
There doesn't seem to be a github pages here, and I think this site is out-of-scope for hackclub.com, @grymmy can you chime in on scope?
reesericci
changed the title
shrey.dino.icu and codethetech.hackclub.com
|
Do we want to close this and have them re-open with a new PR if still needed? |
|
Hey @reesericci i felt i should close this pull request because it's making me too much confusing regarding process . I want this domain but closing due to confusion |
|
Like I said - please feel free to open a new PR! |
|
Sure thanks @reesericci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.