-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGA release #145
Merged
Merged
NGA release #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added static accessiable info, making reading and adding features better - Added override names for specific combinations of augments - Made weapon name viewable in bidding.
GunFactory is a MonoBehaviour and is thus spawned in when one of its static methods is called. In its Start method, it calls InitializeGun to instantiate the gun it is supposed to build. This is *only* useful in the GunTest scene, where we want a gun to show up automatically, based on what the factory starts with. When we use InstantiateGun to create a gun from other scenes, the Start method is also triggered and creates a superfluous copy of the gun. With this commit, the issue is avoided by initializing in InstantiateGun and in Start *only when the scene in GunTest*.
Fix duplicate gun spawning on InitializeGun
Weapon name & static constant readonly variables
These will run through GitHub Actions (https://github.com/hackerspace-ntnu/Prosjekt-Spill-H22/actions), and will automatically add opened+reopened issues with the "TODO 🙃" status, and opened+reopened+ready_for_review pull requests with the "Review" status, to this repo's GitHub project (https://github.com/orgs/hackerspace-ntnu/projects/1). For admins: It's important that the action variables (https://github.com/hackerspace-ntnu/Prosjekt-Spill-H22/settings/variables/actions) are kept up-to-date, in case things like the "Status" option names are changed (https://github.com/orgs/hackerspace-ntnu/projects/1/settings/fields/Status). Code based on the following files: * https://github.com/MAKENTNU/web/blob/e9b2d108df3684120d0d390420b0ffd84d01265d/.github/workflows/_reusable_add-content-to-project.yml * https://github.com/MAKENTNU/web/blob/e9b2d108df3684120d0d390420b0ffd84d01265d/.github/workflows/project-add-issue.yml * https://github.com/MAKENTNU/web/blob/e9b2d108df3684120d0d390420b0ffd84d01265d/.github/workflows/project-add-pull-request.yml
This GitHub Actions workflow will automatically add the "new release" label to pull requests that merge `dev` into `main`, and remove the label in any other case (as this would most likely mean that the label was erroneously added).
...for automatically updating actions used in the workflows (currently only `tibdex/github-app-token`).
…s-for-project-board Add GitHub Actions workflows for adding items to project board
- Replace bidding platform model with one with more suitable UV mapping - Add material that displays a border in the leading bidder's color
…indicator Add leading bidder indicator to bidding platforms
Make volume sliders adjust volume logarithmically to account for how humans perceive sound volume — logarithmically, not linearly.
…settings Fix volume slider scale
Refactor playerInput system
- Terrain with mountains and a valley for the arena - Basic materials - Whiteboxed buildings
Note that this does not fix the underlying issue.
- Use textures instead of colors - Transition smoothly between flatland and hill
…movement Improve player movement
Multiple match support
Add shacks and rocks to CraterTown
- Reload is handled by guncontroller, and reloas is also a gunEvent - Solar body with corresponding Item has been added - todo later: refactor augments to improve reload implmention
Solar body augment
- OnHit implementation not yet added, as we are awaiting some other changes
Also known as *swag*
- Change round end delay to be non-zero again - Add shorter bidding end delay - Use different bidding platform time in editor - Add match end delay
Basically same as death screens just with "the winner is"
Add curch and water tower
Add win screen
Fire extension!
And adjust the label for the bullet speed...
- Remove point lights - Enable directional light with softer shadows - Adjust lighting settings to be more similar
- Appears when players are damaged - Leaps smoothly from 0 to 1 to 0 - Ends at a value greater than 0 if the player is at low health
Add damage border around player HUD
Improve bidding UI
toberge
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's a go
also rip conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the improvements made from milestone 6 to the pre-NGA sprint.