682 pets component #707
Merged
682 pets component #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with main.# the commit.
johnwroge
requested review from
tylerthome,
Joshua-Douglas,
erikguntner,
agosmou,
mira-kine and
JpadillaCoding
erikguntner
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks @johnwroge this looks good! Just a few minor fixes and this should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #682
What changes did you make?
I added a 'pets' type to the FieldTypes type definition, updated the IntakeProfile directory to include a case of 'pets' to display the form elements, added the field to profile.ts file in the services directory, and built an additional pets field component 'AdditionalPetsField' which allows the user to add/remove pets. This component contains a search bar and is limiited to a group of pets and can updated to include other pets as necessary.
Rationale behind the changes?
The intake profile section needs a pets component for guests so they can add any pets they own to their intake profile. This will help coordinators make appropriate matches with hosts who may/may not have preferences for pets.
Testing done for these changes
Tests were run in the app directory with all test cases passing.
What did you learn or can share that is new?(optional)
I learned about representing form components in an alternative way.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied