Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jb.fix.events not showing up for checkin #1413

Merged

Conversation

jbubar
Copy link
Member

@jbubar jbubar commented Jul 11, 2023

starts fixing #1411

What changes did you make and why did you make them ?

  • Made the dropdown render if there are 1 or more checkin ready events in the db
  • Expanded the time frame for creating checkin ready events via changing < and > to <= and >=

Joshua Bubar added 2 commits July 10, 2023 21:34
… 1\n\nIf only one event was checkin ready then the dropdown should display, however it required 2 or more events previously
@jbubar jbubar requested a review from trillium July 11, 2023 04:46
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jbubar-jb.fix.events_not_showing_up_for_checkin development
git pull https://github.com/jbubar/VRMS.git jb.fix.events_not_showing_up_for_checkin

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple changes to force the dropdown to show up for events

@trillium trillium merged commit 83d0981 into hackforla:development Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants