Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Styling System to Use sx Prop in Material-UI Components in styles.js #1848

Closed
5 tasks
93Belen opened this issue Oct 5, 2023 · 0 comments · Fixed by #1884
Closed
5 tasks

Update Styling System to Use sx Prop in Material-UI Components in styles.js #1848

93Belen opened this issue Oct 5, 2023 · 0 comments · Fixed by #1884
Assignees
Labels
dev Code Development Feature: Design System Standards, documentation and guide of design assets and components Material-UI v.5 Update from MUI v.4 to v.5 Release Note: System Update Shows on Release Notes under "Technical Debt" Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs Sprint 03

Comments

@93Belen
Copy link
Member

93Belen commented Oct 5, 2023

Overview

Our project currently utilizes the makeStyles function for styling Material-UI components. However, with the updates in Material-UI version 5, it is recommended to transition to using the sx prop for styling.
Additionally, once we don't use the makeStyles function, we will be able to remove the mui/styles dependency, which has conflicts with React v.18 recently added to our project.
This GitHub issue is part of a series of Issues aiming to update the styling system in our project. In this issue, we are going to update Update Styling System to Use xs Prop in Material-UI Components in components/FoodSeeker/SearchResults/ResultsMap/styles.js

Action Items

  • Replace HTML elements with Material Ui components
  • Replace the existing makeStyles implementation with the xs prop for styling.
  • Ensure that the changes do not impact the styling overrides in the theme folder.
  • Make sure you don't lose accessibility when replacing semantic HTML for Material UI Components
  • Attach screenshots of before and after in PR

Resources/Instructions
https://mui.com/material-ui/getting-started/overview/
https://mui.com/material-ui/migration/migration-v4/

@93Belen 93Belen added dev Code Development Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs Feature: Design System Standards, documentation and guide of design assets and components Release Note: System Update Shows on Release Notes under "Technical Debt" Sprint 03 Material-UI v.5 Update from MUI v.4 to v.5 labels Oct 5, 2023
@sisi-in-tech sisi-in-tech self-assigned this Oct 8, 2023
sisi-in-tech added a commit that referenced this issue Oct 23, 2023
qiqicodes pushed a commit that referenced this issue Nov 21, 2023
qiqicodes added a commit that referenced this issue Nov 21, 2023
Update Styling System to Use sx Prop in Material-UI Components in styles.js (ticket #1848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Code Development Feature: Design System Standards, documentation and guide of design assets and components Material-UI v.5 Update from MUI v.4 to v.5 Release Note: System Update Shows on Release Notes under "Technical Debt" Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs Sprint 03
Projects
Archived in project
2 participants