-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability: selected map pins aren’t prominent enough #923
Comments
|
I uploaded the SVG files onto the team's Google Drive: https://drive.google.com/file/d/1fc89FT-ym50gMZ8BA9ePJ67xi6i_hZPA/view?usp=sharing |
@souronion The G-Drive link above only gives you one of the svg's. The link to the folder of SVGs is https://drive.google.com/file/d/1fc89FT-ym50gMZ8BA9ePJ67xi6i_hZPA Thanks for creating them! |
Cleanup of Issue #923 A/B test code
Record keeping: @entrotech wrote in Slack: @fancyham wrote: The hard right edge is probably because of some editing I did. The clickable area on the map is the entire svg canvas, and the canvas for the original svg was a quite large invisible rectangular area around the new pin, which causes it to overlap any other pins that are under the canvas, making the underlying pins unselectable by the user (for no apparent reason to them). Moreover, there are limited options about which part of the rectangular svg canvas can be anchored to the intended (lat, long) coordinates, and "bottom center" is the appropriate one for our purposes. This means that the rectangular area extends to the left of the pin point as far as it does to the right. To mitigate this, I clipped the invisible part of the svg, but probably went too far to accommodate the entire shadow. It wasn't very noticeable on the devices I tried, but is pretty apparent in Bryan's case. @entrotech wrote: @fancyham fancyham wrote: [other support for option 4…] @souronion wrote: |
We all voted unanimously for version 2, option 4!
entrotech said that clickable area is actually a rectangle, so anywhere there's a dropshadow will eat clicks, even if user was clicking on something somewhat visible behind the dropshadow. So removing or minimizing drop shadow is a good idea. @entrotech will try to reduce shadow and replace, but if can't do that, will do one without a dropshadow. |
@souronion @fancyham Can we close this issue? It has been deployed to production. I wanted to get one last check that it works as you intended. |
@entrotech looks good to me. Good job everyone! |
A selected location makes the map pin a tiny bit larger, but very hard to tell if a pin is selected or normal, and which pin is selected.
Recommend trying:
Make selected map pin selected state more obvious. Significantly or perhaps better: a colored outline or something similar.
For example, Google map pins grow about 50-80% and sometimes change shape.
Apple Maps grows selected location pin about 100%
The text was updated successfully, but these errors were encountered: