Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name and external_id fields to project_url #289

Open
5 tasks
fyliu opened this issue May 31, 2024 · 6 comments
Open
5 tasks

Add name and external_id fields to project_url #289

fyliu opened this issue May 31, 2024 · 6 comments
Labels
complexity: missing feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet good first issue Good for newcomers ready for prioritization role: db architect s: PD team stakeholder: People Depot Team size: 1pt Can be done in 4-6 hours

Comments

@fyliu
Copy link
Member

fyliu commented May 31, 2024

Overview

We need to add name and external_id fields to the project_url table, which was decided here.

Action Items

Resources/Instructions

  • add name field: What the link is called Ex: Primary Repo, Secondary Repo, Description of "other" type urls
  • add external_id field: resource id provided by github or google
  • both fields should be varchar(255) or CharField(max_length=255)
  • external_id can be blank
@fyliu fyliu added role: back end size: 1pt Can be done in 4-6 hours role: db architect s: PD team stakeholder: People Depot Team feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet ready for db architect labels May 31, 2024
@fyliu fyliu added this to the v0.01 - initial setup milestone May 31, 2024
@fyliu fyliu added complexity: small All steps are laid out in detail so that someone new to the project can work on it and removed complexity: missing labels Jun 24, 2024
@shmonks shmonks added good first issue Good for newcomers and removed complexity: small All steps are laid out in detail so that someone new to the project can work on it labels Aug 9, 2024
@shmonks
Copy link
Member

shmonks commented Aug 9, 2024

When submitting the PR for this issue, change the word 'fixes' to 'partially addresses'.

@shmonks
Copy link
Member

shmonks commented Aug 9, 2024

Once assignee has completed the code portion, remove 'backend' label and put back in the Prioritized Backlog for db architect.

@dmartin4820
Copy link
Member

dmartin4820 commented Aug 9, 2024

@fyliu
Copy link
Member Author

fyliu commented Aug 9, 2024

@dmartin4820 I guess this is more of a db design change issue than a coding issue.

Would you want to check that all the items are done and close it? The work would be working with issues and documents rather than coding.

Edit the issue description and replace the "code" step with "update #41 description". Then check that the 3 steps are done and fix or comment about them if they're not editable.

Looks like @Neecolaa already made the ERD changes. Please check that it looks correct and comment here if there's a problem.

The spreadsheet has a "fields" sheet with the table names and fields, and there's an initial data sheet called something like "projectUrls" that you should check. I started updating it before I realized it's something you could do to familiarize yourself with the document. But I'm not going to bother undoing them. Please just check to make sure it's correct.

The issue #41 description also looks updated. But I see a problem with one of the new fields that you can fix. The requirements are in this issue's description so you can check them one by one.

Lastly, check if #78 dependencies are satisfied and, if so, move its status from ice box to new issue approval.

@dmartin4820

This comment was marked as resolved.

@dmartin4820

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet good first issue Good for newcomers ready for prioritization role: db architect s: PD team stakeholder: People Depot Team size: 1pt Can be done in 4-6 hours
Projects
Status: 🆕New Issue Review
Development

No branches or pull requests

4 participants