Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidation of JS files to improve load performance Discussion #117

Closed
ExperimentsInHonesty opened this issue May 27, 2019 · 1 comment
Closed

Consolidation of JS files to improve load performance Discussion #117

ExperimentsInHonesty opened this issue May 27, 2019 · 1 comment
Assignees
@thekaveman @abregorivas @ExperimentsInHonesty
Labels
Complexity: Missing Discussion Starting point for gathering further information and/or feedback Feature Missing This label means that the issue needs to be linked to a precise feature label. HOLD Not ready to be worked on yet Research Tasks for researchers role missing size: missing

Comments

@ExperimentsInHonesty
Copy link
Member

Overview

Light house test shows that we could improve our performance by having a single js file.

On Hold

Reason: pending issue #112 completion

Discussion Item

  • Check to see if Performance is above 80% and determine if it is necessary to do this step
    If it is, discuss with tech lead if its worth the hit to site maintainability .

Action items - on hold

  • Combine the two files into one file called "index.js"
  • Update the default.html script tags to pull in the new index.js file
@ExperimentsInHonesty ExperimentsInHonesty added good first issue Good for newcomers Discussion Starting point for gathering further information and/or feedback HOLD Not ready to be worked on yet Research Tasks for researchers labels May 27, 2019
@abregorivas abregorivas mentioned this issue May 27, 2019
Closed
@ExperimentsInHonesty ExperimentsInHonesty removed the good first issue Good for newcomers label Jun 4, 2019
@ExperimentsInHonesty
Copy link
Member Author

This line of inquiry has been closed. We ended up moving the babel cdn call to bottom of file which improved performance sufficiently. Pull request #125

@ExperimentsInHonesty ExperimentsInHonesty added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thekaveman thekaveman

@abregorivas abregorivas

@ExperimentsInHonesty ExperimentsInHonesty

Labels
Complexity: Missing Discussion Starting point for gathering further information and/or feedback Feature Missing This label means that the issue needs to be linked to a precise feature label. HOLD Not ready to be worked on yet Research Tasks for researchers role missing size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thekaveman @abregorivas @ExperimentsInHonesty @Josiah-O