Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated leadership info on Youth Justice Nav page #3982

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Updated leadership info on Youth Justice Nav page #3982

merged 1 commit into from
Feb 16, 2023

Conversation

bootcamp-brian
Copy link
Member

Fixes #3958

What changes did you make and why did you make them ?

  • Updated the file "_projects/youthjusticenav.md
  • Removed info for Nielsen and Daniel Lee from leadership variable
  • Added info for Rabia Shaikh and Hyun Joo Sandy Oh to leadership variable

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

youthjusticenav-before

Visuals after changes are applied

youthjusticenav-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bootcamp-brian-update-project-profile-3958 gh-pages
git pull https://github.com/bootcamp-brian/website.git update-project-profile-3958

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Feb 15, 2023
@chrismenke45 chrismenke45 self-requested a review February 15, 2023 17:37
chrismenke45
chrismenke45 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@chrismenke45 chrismenke45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All the necessary members have been added and the correct ones were removed. Looks good on the site.

@MarkWiltberger MarkWiltberger requested review from chrismenke45 and removed request for chrismenke45 February 15, 2023 20:59
@MarkWiltberger
Copy link
Member

I inadvertently requested review from Chris again, then removed the request. Apologies.

@RyanGehris RyanGehris self-requested a review February 15, 2023 23:50
@RyanGehris
Copy link
Member

Availability: 4pm-7pm 12/15/2023, 9am-5pm 12/16/2023
ETA: by 7pm on 12/15/2023

RyanGehris
RyanGehris approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@RyanGehris RyanGehris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file changes show that you correctly removed two members from leadership and added two new members. The changes are correctly displayed on the website.

Great work!

@roslynwythe roslynwythe merged commit 98e162c into hackforla:gh-pages Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismenke45 chrismenke45 chrismenke45 approved these changes

@RyanGehris RyanGehris RyanGehris approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Youth Justice Nav
5 participants
@bootcamp-brian @MarkWiltberger @RyanGehris @chrismenke45 @roslynwythe