Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lint-scss.yml to github/super-linter@4.8.1 #6883

Merged

Conversation

t-will-gillis
Copy link
Member

Fixes #6868

What changes did you make?

  • In lint-scss.yml file, reverted linter to previous version github/super-linter@4.8.1

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

n/a

Additional

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-revert-super-linter-6868 gh-pages
git pull https://github.com/t-will-gillis/website.git revert-super-linter-6868

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 22, 2024
@del9ra del9ra self-requested a review May 22, 2024 14:58
@del9ra
Copy link
Member

del9ra commented May 22, 2024

Review ETA: 6 PM 5/23/24
Availability: 3-6 PM Friday

Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis,

  • The correct branch was used for the pull request.
  • The issue was properly linked.
  • The linter was reverted to the previous version correctly.
  • The pull request title is descriptive of the changes.
  • The appearance of the project webpage remains unchanged.
    Nice work and thank you for your contribution!

@t-will-gillis t-will-gillis merged commit 18d4536 into hackforla:gh-pages May 24, 2024
10 checks passed
@t-will-gillis t-will-gillis deleted the revert-super-linter-6868 branch May 24, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert github/super-linter to version 4.8.1
2 participants