Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Eli Marietta in design-systems.md #7342

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

codyyjxn
Copy link
Member

@codyyjxn codyyjxn commented Aug 22, 2024

Fixes #7288

What changes did you make?

  • I updated the _projects/design-systems.md file by inserting a new key, 'github-handle,' directly beneath the name: Eli Marietta

Why did you make the changes (we will use this info to test)?

  • I made this change to streamline the project file by introducing a 'github-handle' key, which replaces the need for separate 'github' and 'picture' entries.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No screenshots since adding a variable did not create any new visual change

@codyyjxn codyyjxn self-assigned this Aug 22, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b codyyjxn-add-github-handle-7288 gh-pages
git pull https://github.com/codyyjxn/website.git add-github-handle-7288

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 22, 2024
@kgold2018 kgold2018 self-requested a review August 22, 2024 21:55
@codyyjxn
Copy link
Member Author

@kgold2018 @MicahBear Hi. Would you please review my pr ?

Copy link
Member

@kgold2018 kgold2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codyyjxn, the changes look good, but please check off all the relevant action items on the original issue. Thank you!

@codyyjxn
Copy link
Member Author

@MicahBear Hi please review my pr.

@bexux bexux self-requested a review August 23, 2024 22:46
Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. PR description is accurate and concise. Great job!

@codyyjxn codyyjxn removed the request for review from MicahBear August 24, 2024 00:19
@t-will-gillis t-will-gillis merged commit 640f7a7 into hackforla:gh-pages Aug 25, 2024
10 checks passed
@t-will-gillis
Copy link
Member

Hey @codyyjxn For future reference, you do not need to assign yourself to your own PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Eli Marietta in design-systems.md
4 participants