Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove surveillance-card from blacklist #468

Closed
wants to merge 1 commit into from

Conversation

niemyjski
Copy link

I've updated the repository (https://github.com/custom-cards/surveillance-card) with the hacs.json file and I've been using this card for a long while and it works on 0.110.

Before you submit a pull request, please make sure you have done the following:

  • You are submitting only 1 repository.
  • You repository is compliant with https://hacs.xyz/docs/publish/start
  • You have tested it with HACS by adding it as a custom repository.
  • The list are still alphabetical after my change.

I've updated the repository (https://github.com/custom-cards/surveillance-card) with the hacs.json file and I've been using this card for a long while and it works on `0.110`.
@ludeeus
Copy link
Member

ludeeus commented May 26, 2020

#318 is the reason it was removed, not a missing hacs.json file.

By looking at the repo, I see 1,5y old unanswered issues, this is not a sign of something that still is maintained.
So at this point I will not deblacklist this.

@ludeeus ludeeus closed this May 26, 2020
@niemyjski
Copy link
Author

niemyjski commented May 26, 2020

What do you mean not maintained or used? I’ve done prs/added stuff to it and use it every day. Have you considered maybe it’s stable? It’s an open source project, I’ll add a stale bot to the repo to make it look more active like the official HA repos.

@niemyjski
Copy link
Author

niemyjski commented May 26, 2020

Also I wish I could easily know why it was blacklisted in the first place, perhaps add a reason to the blacklist?

@ludeeus
Copy link
Member

ludeeus commented May 26, 2020

Maintained == someone is monitoring and answering issues.
If you use it every day, I suggest you contact the current maintainer to get access to the repo.
If you (or someone else) takes over it, I'll gladly remove it from the blacklist.

As for the reason that is shown here: https://github.com/hacs/default/blob/master/removed#L247-L250

@niemyjski
Copy link
Author

I started to maintain it and fix the issues I see.. but I’ve been convinced to just fork it and add my own repo so I don’t have to see the warnings anymore. Thanks for your time.

@iantrich
Copy link
Contributor

@niemyjski I've added you as a maintainer to the repo.

@niemyjski niemyjski deleted the patch-1 branch May 26, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants