Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary hybrid evaluation handlers #113

Closed
romainfrancois opened this issue Nov 8, 2013 · 4 comments
Closed

Binary hybrid evaluation handlers #113

romainfrancois opened this issue Nov 8, 2013 · 4 comments
Assignees
Labels
feature a feature request or enhancement
Milestone

Comments

@romainfrancois
Copy link
Member

We now have all the scaffolding to add binary hybrid handlers, e.g. +, -, == at least handling scalar values, so that we can hybridify something like this:

sum( x < 3 )

We know how to handle sum, but since we can't hybrid x<3 the hybrid version of sum is not used.

@hadley
Copy link
Member

hadley commented Aug 1, 2014

@romainfrancois do think you can tackle this with the other hybrid evaluator changes? Or should we push off to a future version? I'm aiming to get dplyr 0.3 to CRAN by mid-September.

@romainfrancois romainfrancois self-assigned this Sep 22, 2014
@romainfrancois
Copy link
Member Author

For this to really be useful, we would have to specialize precisely for each case, i.e. at the point where we see the expression sum( x < 3 ) we would instantiate a class like Sum_LowerThan.

Otherwise, within hybrid eval, we would first substitute x < 3 to some logical vector and then sum that which demands more memory and runtime .

@hadley hadley modified the milestones: 0.4, 0.3 Sep 23, 2014
@hadley
Copy link
Member

hadley commented Sep 23, 2014

Let's put this off until (at least) 0.4

@hadley hadley added feature a feature request or enhancement data frame and removed internal labels Oct 22, 2015
@hadley
Copy link
Member

hadley commented Mar 1, 2016

I'm going to close this for now. I think we should come back to again in the future if we look for potential performance gains.

@hadley hadley closed this as completed Mar 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants