Better error messages for stat_bin #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' By default, \code{geom_bar} uses \code{stat="bin"}. This makes the height | ||
| #' of each bar equal to the number of cases in each group, and it is | ||
| #' incompatible with mapping values to the \code{y} aesthetic. If you want | ||
| #' the heights of the bars to be represent values in the data, use |
|
I've changed the error to a very long warning message. Even though it's really long, I think it is worth keeping, since this is probably a very common issue and it can be confusing. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #632. It provides clearer error messages when the user makes a graph with
stat_binand also maps something to ayvalue.A couple notes:
geom_barmight not even realize that they're usingstat="bin".stat="bin"and map values to y, provided that there's only one y value per group. This could possibly affect a lot of existing code.It should also have some tests added.