Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading tags when repository has been transferred to another user #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

randrescastaneda
Copy link

@randrescastaneda randrescastaneda commented Apr 26, 2022

Dear @haghish ,

First of all, thank you so much for the github command. It is fantastic. I think it will revolutionize the way people work and contribute in Stata.

Problem

I found an issue with github query when a repo has been transferred to a new user. My understanding of the problem is that the Github API returns values in a different order when the repo has been transferred. In the first image below, the current version of github works fine when I query the original repo pip-technical-team/pip, but It fails when I call the new official repo, worldbank/pip (second image).

working fine

image

Failing

image

Solution

In this PR, I made some modifications so it always reads the tags correctly.
image

Best,

@haghish
Copy link
Owner

haghish commented Aug 15, 2022

thanks a lot for your work. can you update the code to support Stata 14 and up?

@randrescastaneda
Copy link
Author

thanks a lot for your work. can you update the code to support Stata 14 and up?

DONE!

Unless I am doing something wrong, I changed to version 14 at the top of the githubquery.ado file and it kept working fine.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants