Migrate to github actions

.github/workflows/ci.yml

@@ -0,0 +1,180 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - ha/migrate-to-github-actions
+
+env:
+  CI: true
+  BUILDKITE: true
+  RAILS_ENV: test
+  RACK_ENV: test
+  MYSQL_HOST: 127.0.0.1
+  MYSQL_PORT: 3306
+  REDIS_HOST: redis
+  REDIS_PORT: 6379
+  PGHOST: 127.0.0.1
+  PGUSER: postgres
+  PGPORT: 5432
+  BUNDLE_DEPLOYMENT: false
+  BEANSTALK_URL: "beanstalk://127.0.0.1:11300"
+  RABBITMQ_URL: "amqp://guest:guest@127.0.0.1:5672"
+  QC_DATABASE_URL: "postgres://postgres@127.0.0.1/active_jobs_qc_int_test"
+  # Sauce Labs username and access key. Obfuscated, purposefully not encrypted.
+  ENCODED: "U0FVQ0VfQUNDRVNTX0tFWT1hMDM1MzQzZi1lOTIyLTQwYjMtYWEzYy0wNmIzZWE2MzVjNDggU0FVQ0VfVVNFUk5BTUU9cnVieW9ucmFpbHM="
+
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby }} - ${{ matrix.framework }}
+    runs-on: ubuntu-latest
+    services:
+      mysql:
+        image: mysql:latest
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
+        ports:
+          - 3306:3306
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+      postgres:
+        image: postgres:alpine
+        env:
+          POSTGRES_HOST_AUTH_METHOD: trust
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 3
+      selenium:
+        image: selenium/standalone-chrome:latest
+        ports:
+          - 4444:4444
+    strategy:
+      fail-fast: false
+      matrix:
+        experimental: [false]
+        ruby: [3.2, 3.1, 3.0, 2.7]
+        framework: [actioncable, actionmailbox, actionmailer, actionpack, actiontext, actionview, activemodel, activerecord_sqlite3, activerecord_mysql2, activerecord_trilogy, activerecord_postgresql, activestorage, activesupport, railties, actioncable_integration, actionview_ujs, activejob_integration, actiontext_integration, guides]
+        include:
+          - ruby: head
+            experimental: true
+    outputs:
+      data: ${{ steps.create_steps.outputs.data }}
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Create steps
+        id: create_steps
+        run: |
+          declare -A data=(
+            ["actioncable"]="test,default"
+            ["actionmailbox "]="test,default"
+            ["actionmailer"]="test,default"
+            ["actionpack"]="test,default"
+            ["actiontext"]="test,default"
+            ["actionview"]="test,default"
+            ["activejob"]="test,default"
+            ["activemodel"]="test,default"
+            ["activerecord_sqlite3"]="sqlite3:test,default"
+            ["activerecord_mysql2"]="db:mysql:rebuild,mysql2:test,mysqldb"
+            ["activerecord_trilogy"]="db:mysql:rebuild,trilogy:test,mysqldb"
+            ["activerecord_postgresql"]="db:postgresql:rebuild,postgresql:test,postgresdb"
+            ["activestorage"]="test,default"
+            ["activesupport"]="test,default"
+            ["railties"]="test,default"
+            ["actioncable_integration"]="test:integration,default"
+            ["actionview_ujs"]="test:ujs,default"
+            ["activejob_integration"]="test:integration,default"
+            ["actiontext_integration"]="test:system,default"
+            ["guides"]="test,default"
+          )
+
+          echo "frameworks_data=${data[${{ matrix.framework }}]}" >> "$GITHUB_ENV"
+
+      - name: Install dependencies
+        run: |
+          codename="$(. /etc/os-release; x="${VERSION_CODENAME-${VERSION#*(}}"; echo "${x%%[ )]*}")"
+          if ! which gpg || ! which curl; then \
+            apt-get update \
+            && apt-get install -y --no-install-recommends \
+                gnupg curl; \
+          fi
+          # Postgres apt sources
+          sudo curl -sS https://www.postgresql.org/media/keys/ACCC4CF8.asc | APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE=1 sudo apt-key add -
+          sudo add-apt-repository "deb http://apt.postgresql.org/pub/repos/apt/ ${codename}-pgdg main"
+          # Node apt sources
+          sudo  curl -sS https://deb.nodesource.com/gpgkey/nodesource.gpg.key | APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE=1 sudo apt-key add -
+          sudo add-apt-repository "deb http://deb.nodesource.com/node_18.x ${codename} main"
+          # Yarn apt sources
+          sudo curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE=1 sudo apt-key add -
+          sudo add-apt-repository "deb http://dl.yarnpkg.com/debian/ stable main"
+          # Install dependencies
+          sudo apt-get install -y --no-install-recommends \
+          imagemagick \
+          postgresql-client \
+          libmysqlclient-dev \
+          default-mysql-client \
+          sqlite3 \
+          nodejs \
+          yarn \
+          ffmpeg \
+          mupdf \
+          mupdf-tools \
+          poppler-utils \
+          libvips-dev \
+          libwebp-dev \
+          beanstalkd
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: false
+          rubygems: latest
+          bundler: latest
+
+      - name: Install bundler dependencies
+        run: bundle config unset deployment && bundle install --jobs 4 --retry 3
+        timeout-minutes: 3
+
+      - name: Set up Redis
+        uses: supercharge/redis-github-action@1.2.0
+
+      - name: Set up Memcached
+        uses: niden/actions-memcached@v7
+
+      - name: Start RabbitMQ container
+        if: ${{ matrix.framework == 'activejob_integration'}}
+        run: |
+          docker run -d --name rabbitmq -p 5672:5672 -p 15672:15672 -e RABBITMQ_DEFAULT_USER=guest -e RABBITMQ_DEFAULT_PASS=guest rabbitmq:alpine
+
+      - name: MYSQL - Grant all privileges to rails user
+        run: |
+          mysql -h 127.0.0.1 -P 3306 -u root -e "
+            create user 'rails'@'%';
+            grant all privileges on activerecord_unittest.* to rails@'%';
+            grant all privileges on activerecord_unittest2.* to rails@'%';
+            grant all privileges on inexistent_activerecord_unittest.* to rails@'%';
+            create database activerecord_unittest default character set utf8mb4;
+            create database activerecord_unittest2 default character set utf8mb4;
+          "
+
+      - name: npm install
+        timeout-minutes: 3
+        run: npm install
+
+      - name: ${{ matrix.framework }}
+        run: |
+          framework=$(echo "${{ matrix.framework }}" | cut -d_ -f1)
+          cd $framework
+          echo "frameworks_data: $frameworks_data"
+          instructions=$(echo $frameworks_data | sed 's/,[^,]*$//')
+          if [[ $instructions == *,* ]]; then
+            instructions=$(echo "$instructions" | sed 's/,/ \&\& bundle exec rake /g')
+          fi
+          instructions="bundle exec rake $instructions"
+          echo "instructions: $instructions"
+          eval $instructions

.github/workflows/lint.yml

@@ -12,7 +12,7 @@ jobs:
       BUNDLE_WITHOUT: db:job:cable:storage:ujs
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Set up Ruby 3.2
       uses: ruby/setup-ruby@v1
@@ -27,26 +27,16 @@ jobs:
       uses: actions/setup-python@v3
       with:
         python-version: "3.10"
+
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
         pip install codespell==2.1.0
     - name: Check spelling with codespell
       run: codespell --ignore-words=codespell.txt --skip="./vendor/bundle,./actionview/test/ujs/public/vendor/qunit.js,./actiontext/app/assets/javascripts/trix.js,./yarn.lock" || exit 1
 
-    - uses: actions/checkout@v3
-      with:
-        repository: skipkayhil/rails-bin
-        ref: 748f4673a5fe5686b5859e89f814166280e51781
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 3.2
-        bundler-cache: true
-    - uses: actions/checkout@v3
-      with:
-        path: rails
-    - run: bin/check-changelogs ./rails
-    - run: bin/check-config-docs ./rails
+    - run: tools/railspect changelogs .
+    - run: tools/railspect configuration .
 
     - uses: zzak/action-discord@v8
       continue-on-error: true

.github/workflows/rail_inspector.yml

@@ -0,0 +1,24 @@
+name: Rail Inspector
+
+on:
+  pull_request:
+    paths:
+    - "tools/rail_inspector/**"
+  push:
+    paths:
+    - "tools/rail_inspector/**"
+
+permissions:
+  contents: read
+
+jobs:
+  rail_inspector:
+    name: rail_inspector tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+      - run: cd tools/rail_inspector && bundle exec rake

.github/workflows/rails-new-docker.yml

@@ -11,7 +11,7 @@ jobs:
   rails-new-docker:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: '3.2'

.github/workflows/rubocop.yml

@@ -12,7 +12,7 @@ jobs:
       BUNDLE_ONLY: rubocop
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Set up Ruby 3.2
       uses: ruby/setup-ruby@v1

.rubocop.yml

@@ -19,6 +19,7 @@ AllCops:
     - 'actionmailbox/test/dummy/**/*'
     - 'activestorage/test/dummy/**/*'
     - 'actiontext/test/dummy/**/*'
+    - 'tools/rail_inspector/test/fixtures/*'
     - '**/node_modules/**/*'
     - '**/CHANGELOG.md'
     - '**/2_*_release_notes.md'
@@ -242,6 +243,9 @@ Lint/RequireParentheses:
 Lint/RedundantStringCoercion:
   Enabled: true
 
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
 Lint/UriEscapeUnescape:
   Enabled: true
 
@@ -350,6 +354,9 @@ Minitest/AssertRaisesWithRegexpArgument:
 Minitest/AssertWithExpectedArgument:
   Enabled: true
 
+Minitest/LiteralAsActualArgument:
+  Enabled: true
+
 Minitest/SkipEnsure:
   Enabled: true
 

Gemfile

@@ -45,6 +45,10 @@ gem "json", ">= 2.0.0"
 # Workaround until Ruby ships with cgi version 0.3.6 or higher.
 gem "cgi", ">= 0.3.6", require: false
 
+group :lint do
+  gem "syntax_tree", "6.1.1", require: false
+end
+
 group :rubocop do
   gem "rubocop", ">= 1.25.1", require: false
   gem "rubocop-minitest", require: false
@@ -150,12 +154,12 @@ platforms :ruby, :windows do
   gem "racc", ">=1.4.6", require: false
 
   # Active Record.
-  gem "sqlite3", "< 1.6.4"
+  gem "sqlite3", "~> 1.6", ">= 1.6.6"
 
   group :db do
     gem "pg", "~> 1.3"
     gem "mysql2", "~> 0.5"
-    gem "trilogy", github: "github/trilogy", branch: "main", glob: "contrib/ruby/*.gemspec"
+    gem "trilogy", ">= 2.5.0"
   end
 end