Initial fixes for #883:

- I've added the 'name' property wherever I couldn't see any.
- I called the layers 'coreFoo' or 'pluginFoo' so far, depending on if the layer is added in Core or by a Plugin. I'm not sure this is the best way to go, perhaps we could use another prefix or syntax.
- Those layers that already had a 'type' property were not modified: I only added (duplicated) the existing value from 'type', while keeping it. Replacing 'type' with 'name' will require more search-and-replace, which I'm not doing right now.

new-client/src/components/Search/MapViewModel.js

@@ -92,12 +92,16 @@ class MapViewModel {
         ? this.featureStyle.getDefaultSearchResultStyle
         : null
     );
+    // FIXME: Remove "type", use only "name" throughout
+    // the application. Should be done as part of #883.
     this.resultsLayer.set("type", "searchResultLayer");
+    this.resultsLayer.set("name", "pluginSearchResults");
     this.drawSource = this.getNewVectorSource();
     this.drawLayer = this.getNewVectorLayer(
       this.drawSource,
       this.getDrawStyle()
     );
+    this.drawLayer.set("name", "pluginSearchDraw");
     this.map.addLayer(this.drawLayer);
     this.map.addLayer(this.resultsLayer);
   };

new-client/src/models/DrawModel.js

@@ -174,6 +174,9 @@ class DrawModel {
     // TODO: Make sure type is the way to go, a bit confusing setting the
     // layer name on that property. Hmm...
     this.#drawLayer.set("type", this.#layerName);
+    // FIXME: Remove "type", use only "name" throughout
+    // the application. Should be done as part of #883.
+    this.#drawLayer.set("name", this.#layerName);
     // Then we can add the layer to the map.
     this.#map.addLayer(this.#drawLayer);
   };

new-client/src/models/KmlModel.js

@@ -126,6 +126,9 @@ class KmlModel {
     // TODO: Make sure type is the way to go, a bit confusing setting the
     // layer name on that property. Hmm...
     this.#kmlLayer.set("type", this.#layerName);
+    // FIXME: Remove "type", use only "name" throughout
+    // the application. Should be done as part of #883.
+    this.#kmlLayer.set("name", this.#layerName);
     // Then we can add the layer to the map.
     this.#map.addLayer(this.#kmlLayer);
   };

new-client/src/plugins/Collector/CollectorModel.js

@@ -336,6 +336,7 @@ class CollectorModel {
     });
 
     this.layer = new Vector({
+      name: "pluginCollector",
       source: this.vectorSource,
       style: this.getVectorStyle(),
     });

new-client/src/plugins/Edit/EditModel.js

@@ -459,6 +459,7 @@ class EditModel {
     });
 
     this.layer = new Vector({
+      name: "pluginEdit",
       source: this.vectorSource,
       style: this.getVectorStyle(),
     });

new-client/src/plugins/FmeServer/models/MapViewModel.js

@@ -52,6 +52,9 @@ class MapViewModel {
     );
     // Make sure to set the layer type to something understandable.
     this.#drawLayer.set("type", "fmeServerDrawLayer");
+    // FIXME: Remove "type", use only "name" throughout
+    // the application. Should be done as part of #883.
+    this.#drawLayer.set("name", "fmeServerDrawLayer");
     // Then we can add the layer to the map.
     this.#map.addLayer(this.#drawLayer);
   };

new-client/src/plugins/Measure/MeasureModel.js

@@ -13,6 +13,7 @@ class MeasureModel {
     this.localObserver = settings.localObserver;
     this.source = new VectorSource();
     this.vector = new VectorLayer({
+      name: "pluginMeasure",
       source: this.source,
       style: this.createStyle,
     });