Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #1054

Closed
2 tasks done
jacobwod opened this issue Apr 7, 2022 · 0 comments
Closed
2 tasks done

Upgrade to React 18 #1054

jacobwod opened this issue Apr 7, 2022 · 0 comments
Assignees
@jacobwod
Milestone
3.10

Comments

@jacobwod
Copy link
Member

jacobwod commented Apr 7, 2022 •
edited
Loading

Make sure to follow up on these changes: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis.

Occurrences (and status):

  • index.js
  • DocumentHandler's PrintWindow
@jacobwod jacobwod added this to the 3.10 milestone Apr 7, 2022
@jacobwod jacobwod self-assigned this Apr 7, 2022
jacobwod added a commit that referenced this issue May 4, 2022
@jacobwod
Removed the callback in PrintWindow to allow for React 18 migration, c…
23275fe 
…loses #1054.
jacobwod added a commit that referenced this issue Jun 16, 2022
@jacobwod
Revert "Removed the callback in PrintWindow to allow for React 18 mig…
cafc919 
…ration, closes #1054."

This reverts commit 23275fe.

Because we go back to the pre React 18 render method in PrintWindow, this commit reopens #1054. Should close #1107 though.
@jacobwod jacobwod reopened this Jun 16, 2022
@jacobwod jacobwod modified the milestones: 3.10, 3.11 Jun 16, 2022
@jacobwod jacobwod mentioned this issue Jun 22, 2022
Closed
@jacobwod jacobwod modified the milestones: 3.11, 3.10 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
None yet
Projects
None yet
Milestone
3.10
Development

No branches or pull requests
1 participant
@jacobwod